search

mseemann / angular2-mdl

Angular 2 - 14 components, directives and styles based on material design lite (npm: @angular-mdl/core)
https://mseemann.io/angular2-mdl
MIT License
558 stars 93 forks source link

Changes not getting reflected when used in component with OnPush changeDetectionStrategy #145

Open shripalsoni04 opened 8 years ago

shripalsoni04 commented 8 years ago

First of all, thank you so much for creating such useful library. Great work 👍 .

I am trying to use mdl-textfield and mdl-checkbox inside child component which has changeDetection set to OnPush strategy.

The problem is, whenever the input is changed for this child component, that changes are not getting reflected in the mdl components. I forked the demo plunker and did changes to show this issue. You can check it at http://plnkr.co/edit/qRYdXrESNBP8EtAC1tug?p=preview

As you can see in the app, when app loads, the mdl components are not setting the initial data and when you click on "Change Data" button, mdl components are loading old data and floating label is not getting placed properly.

Let me know if I am doing something wrong here.

mseemann commented 8 years ago

interesting! from my understanding of OnPush this should work. right now i can't see anything the component could do to fix this. changing the changeDetection to ChangeDetectionStrategy.OnPush for mdl-textfield did not fix this (as expected - because mdl-checkbox is using OnPush already). Give me some time to investigate this...

mseemann commented 8 years ago

issue created: https://github.com/angular/angular/issues/12607. Let's see what the angular team is saying about this.

mseemann commented 8 years ago

this seems to be the "main issue": https://github.com/angular/angular/issues/10816

cerebroo commented 6 years ago

any updates on this?

I really need to use onPush in my projects and blocked because of this.