msel-source / meflib

Multiscale Electrophysiology Format library
Other
3 stars 2 forks source link

ESti and CStri record implementations #25

Open MaxvandenBoom opened 4 years ago

MaxvandenBoom commented 4 years ago

Hi Jan and Dan,

By chance I noticed that there is a record type MEFREC_ESti_TYPE_CODE that exists, but its implementation is missing in the show_record function in mefrec.h. Note that MEFREC_ESti_TYPECODE is different from the MEFRECCSti_TYPE_CODE.

Also line 191 in mefrec.h seems by context about CSti but the line itself read ESti. Has one been replaced by the other?

Best, Max

cimbi commented 4 years ago

ESti and CSti are my doing. They stand for electrical stimulation events an cognitive stimulation events. Feel free to correct as you deep necessary. They seem to be working fine for me through pymef. Will you correct it or should I do it? I don't have much time at the moment though

MaxvandenBoom commented 4 years ago

Ok, thanks for clarifying! I guess there is no rush, so I can make a PR with an implementation