msel-source / pymef

Python wrapper for MEF library
Other
5 stars 3 forks source link

Fixes on the initialization of section 2 metadata #27

Closed MaxvandenBoom closed 2 years ago

MaxvandenBoom commented 2 years ago

Hey Dan,

I have a couple of fixes and updates on PyMef, I will post them in serial as separate pull requests for clarity.

I noticed that not all the fields are initialized in _initialize_tmd2 (after create_tmd2_dtype) and _initialize_vmd2 (after create_vmd2_dtype), so I added the missing fields. I assume there was not a deliberate reason to leave them out?

I also switched the order a bit within the initialization functions, so it matches the order of the c-structs, I think it's easier to keep track that way.

Best, Max