msel-source / pymef

Python wrapper for MEF library
Other
5 stars 3 forks source link

Implementation of map_indices_flag & argument to copy metadata to dictionaries #36

Closed MaxvandenBoom closed 1 year ago

MaxvandenBoom commented 1 year ago

Hi!

This PR has two enhancements for the read_mef_session_metadata, read_mef_channel_metadata and read_mef_segment_metadata functions:

  1. Finishes the implementation of the map_indices_flag. This optional argument was already present but did not do anything, now it does.

  2. It adds an additional optional argument (copy_metadata_to_dict) to copy the metadata solely into standard python dictionaries and return that to the user; instead of returning a dictionary that often branches into numpy structured array objects that have pointers to underlying C data.

Hope these enhancements are acceptable @cimbi I'll do one last PR after this one to see if I can fix Tom his issue, thanks!!

Best, Max

MaxvandenBoom commented 1 year ago

@cimbi Guess there's still some issues to resolve to pass the tests, I'll let you know when it's ready

cimbi commented 1 year ago

The tests are passing. Merging...

tjr1 commented 1 year ago

This is nice upgrade Max! I'm going to use this!