mseryn / mantis-monitor

Mantis-monitor, a suite to perform code-external profiling using a range of standard profiling tools and producing one data format
GNU Lesser General Public License v2.1
1 stars 0 forks source link

Simplify nvidia-smi collection a bit #48

Closed hgreenbl closed 2 years ago

hgreenbl commented 2 years ago

Output should be identical, but I haven't tested this.


AFAICT the docs don't explicitly guarantee that the output column order will match the order supplied to query-gpu, but it would be weird to offer noheader otherwise.


It may be necessary to manually insert empty columns in some collectors, but in this case

so it's safe to fill them in as they're encountered.


Is there a particular reason to expect lines of less than two fields? (Or is that check just to prevent crashes? Because it doesn't, if the field count is greater than 2 but less than len(measurements)+2. Also, if so, should probably emit a warning once we get logging fixed.)