search

msevestre / monologue_image_upload

Extension managing image upload for the monologue engine
MIT License
6 stars 23 forks source link

Not working with Rails 4.1.0 #2

Closed modelltw closed 9 years ago

modelltw commented 10 years ago

The extension depends on 4.0.x (~> 4.0.0), so won't work with 4.1.0 and beyond. I believe it's safe to open up the dependency to 4.1 since the changes of 4.1 won't impact on the extension's functionality.

msevestre commented 10 years ago

Agreed. Could you submit a problem for that? On Jul 24, 2014 11:38 AM, "modelltw" notifications@github.com wrote:

The extension depends on 4.0.x (~> 4.0.0), so won't work with 4.1.0 and beyond. I believe it's safe to open up the dependency to 4.1 since the changes of 4.1 won't impact on the extension's functionality.

— Reply to this email directly or view it on GitHub https://github.com/msevestre/monologue_image_upload/issues/2.

jipiboily commented 10 years ago

I think @msevestre meant a PR? :grimacing:

msevestre commented 10 years ago

lol.. yeah .... auto correction feature from phone :) Thanks bro

On Fri, Jul 25, 2014 at 1:14 PM, Jean-Philippe Boily < notifications@github.com> wrote:

I think @msevestre https://github.com/msevestre meant a PR? [image: :grimacing:]

— Reply to this email directly or view it on GitHub https://github.com/msevestre/monologue_image_upload/issues/2#issuecomment-50178111 .

modelltw commented 10 years ago

I have submit a pull request, so we can close this one.