search

msfeldstein / chrome-media-keys

Chrome extension that adds media keys to most web music players
GNU Affero General Public License v3.0
89 stars 33 forks source link

Support for musicforprogramming.net #109

Closed PeterMinin closed 7 years ago

PeterMinin commented 7 years ago

When somebody has time, it would be nice to add a controller for musicforprogramming.net. I think the next/previous buttons should work as +/-30s when playing and, optionally, switch between the tracks when stopped.

msfeldstein commented 7 years ago

just pushed in 4.51 should be available soon, thanks for the suggestion, and this site is great.

PeterMinin commented 7 years ago

Agreed :) Thank you!

PeterMinin commented 7 years ago

There's a minor problem: for some reason, the title "Music for Programming" is scrolling when I open the popup. If I press Play/Pause in it, the scrolling stops, and it's clear that the title fits in the width. If I swap the title and the artist, this starts to affect both of them.

Also, the site has a kind of album art, which can be added by a constant link:

controller.override('getAlbumArt', function() {
  return "http://musicforprogramming.net/img/folder.jpg"
})
msfeldstein commented 7 years ago

cool i will add this. And yeah the marquee effect seems to have some issues which i can take a look at separately, or maybe @Ustice has an idea what the problem is.