search

msfeldstein / chrome-media-keys

Chrome extension that adds media keys to most web music players
GNU Affero General Public License v3.0
89 stars 33 forks source link

Pandora has stopped working #120

Open kevindb opened 7 years ago

kevindb commented 7 years ago

Media Keys recently stopped working with pandora.com. It simply always reports "There's nothing playing right now" (see attached screenshot). The timeline seems like it would fit the June 20 release of 4.60. If there's anything else I can do to help, such as providing logs or testing, just let me know. Thank you for a wonderful extension!

screen shot 2017-06-26 at 7 57 59 am

RadValentin commented 7 years ago

@kevindb The way the plugin works is by looking for page elements with certain CSS classes and clicks them to play/pause/etc. Can you check that the classes defined here match the playback buttons in Pandora.

kevindb commented 7 years ago

The class names in the second section (starting on line 25) are correct. However, I suspect the isPlaying section is outdated. If I understand your code, Line 49 is looking for a string "#ic_pause". When I inspect the svg, the xlink:href does not contain the string "#ic_pause".

This is what it looks like when music IS playing:

screen shot playing

This is when the music IS NOT playing:

screen shot paused

Could this be the cause of the issue?

RadValentin commented 7 years ago

Yep, most likely, you'd need to check the aria attribute aria-labelledby to determine the play/pause state.

kevindb commented 7 years ago

If you wanted to continue using the attribute xlink:href, you could look for the string #controls_pause or #controls_play instead of the current #ic_pause.

kevindb commented 7 years ago

I just that extension v4.61 is working with Pandora. Thank you!

kevindb commented 7 years ago

I spoke too soon. The extension has not been working with Pandora for the last two days.

kevindb commented 7 years ago

Could we reopen this issue, please? Pandora has stopped working, with the same behavior as I originally described.