search

msfeldstein / chrome-media-keys

Chrome extension that adds media keys to most web music players
GNU Affero General Public License v3.0
89 stars 33 forks source link

Added support for sites using SCM player #60

Closed pixelyunicorn closed 9 years ago

pixelyunicorn commented 9 years ago

This adds support for the many sites using SCM Player, including thousands of blogs hosted on tumblr. :boom:

SCM player doesn't support album art, so it won't appear the popup.

image

(You could also enable this across the entire internet by modifying the mappings to search for 'scm.html' in the url path)

msfeldstein commented 9 years ago

(You could also enable this across the entire internet by modifying the mappings to search for 'scm.html' in the url path)

Could you be more specific what you mean here?

msfeldstein commented 9 years ago

But this is a great pull request thanks! Pushing 3.94 now

pixelyunicorn commented 9 years ago

Right now, you mappings.coffee file is limited to hostnames (match within domain.)

If there was a way to create a wildcard domain and enabling media keys for any page with scm.html in the path, it would enable every site using SCM player regardless of the hostname.