search

msfeldstein / chrome-media-keys

Chrome extension that adds media keys to most web music players
GNU Affero General Public License v3.0
89 stars 33 forks source link

Scrobbling always gives 'Null' as artist on soundcloud #65

Closed joshkaplan closed 9 years ago

joshkaplan commented 9 years ago

I have only tried SoundCloud, but problem may exist for other services as well. screenshot 2015-06-17 14 17 43

msfeldstein commented 9 years ago

For something like soundcloud where there isn't really a clear separation between artist and title, would it be appropriate to just put the whole track name in the track title and just not send an artist?

joshkaplan commented 9 years ago

Hmm yeah it's tough. Could probably throw together some regex that tries to parse it out, not sure how error prone it would be tho

msfeldstein commented 9 years ago

I just pushed v4.12 which has a simple version of artist / title splitting, it should work well for most cases, and also return an empty string instead of null when it can't. Should keep your scrobblelist cleaner. Let me know what you think!

On Sat, Jun 20, 2015 at 7:24 AM Josh Kaplan notifications@github.com wrote:

Hmm yeah it's tough. Could probably throw together some regex that tries to parse it out, not sure how error prone it would be tho

— Reply to this email directly or view it on GitHub https://github.com/msfeldstein/chrome-media-keys/issues/65#issuecomment-113774959 .

joshkaplan commented 9 years ago

Looks good to me!