search

msfeldstein / chrome-media-keys

Chrome extension that adds media keys to most web music players
GNU Affero General Public License v3.0
89 stars 33 forks source link

add albumkings.co #75

Closed cwaldau closed 9 years ago

msfeldstein commented 9 years ago

Sweet! I will push 4.31 shortly

cwaldau commented 9 years ago

I love the addon and I am always lost when it doesn't work on a site I use! Next I am trying to get Apple Music to work as well, but since the player is loaded through javascript it isn't finding the elements I declare to watch for play/pause state

msfeldstein commented 9 years ago

ooh good call! I can looks into that as well

On Tue, Sep 29, 2015 at 11:06 AM Christopher Waldau < notifications@github.com> wrote:

I love the addon and I am always lost when it doesn't work on a site I use! Next I am trying to get Apple Music to work as well, but since the player is loaded through javascript it isn't finding the elements I declare to watch for play/pause state

— Reply to this email directly or view it on GitHub https://github.com/msfeldstein/chrome-media-keys/pull/75#issuecomment-144138191 .

cwaldau commented 9 years ago

using https://itunes.apple.com/us/post/idsa.99ad7481-3242-11e5-8c89-5ea061d85a5e

I have declared "#pButton" as playStateSelector and "pause" as playStateClass but getting error message "Uncaught SyntaxError: Failed to execute 'querySelector' on 'Document': The provided selector is empty."

Any ideas?

msfeldstein commented 9 years ago

Can you push your code to a branch so i could take a look? It sounds like you're passing an empty query selector (or an empty selector is getting passed somehow i should say). Do you have any empty selectors defined like playSelector: "" or something?

On Tue, Sep 29, 2015 at 11:19 AM Christopher Waldau < notifications@github.com> wrote:

using https://itunes.apple.com/us/post/idsa.99ad7481-3242-11e5-8c89-5ea061d85a5e

I have declared "#pButton" as playStateSelector and "pause" as playStateClass but getting error message "Uncaught SyntaxError: Failed to execute 'querySelector' on 'Document': The provided selector is empty."

Any ideas?

— Reply to this email directly or view it on GitHub https://github.com/msfeldstein/chrome-media-keys/pull/75#issuecomment-144144192 .

cwaldau commented 9 years ago

oh... your right I took out my empty selectors and its working... sorry! Ill push the code soon then.