msfeldstein / chrome-media-keys

Chrome extension that adds media keys to most web music players
GNU Affero General Public License v3.0
89 stars 33 forks source link

Pocket Casts support #85

Closed mbirth closed 8 years ago

mbirth commented 8 years ago

Please add support for the Pocket Casts web player: https://play.pocketcasts.com/web

msfeldstein commented 8 years ago

Hey markus, Since this is a paid service, I'd need to borrow someone's account to fix it up. Or if you're a developer you can also fix it and make a PR, it used to work so it should be a simple fix.

mbirth commented 8 years ago

I didn't find a Pocket Casts controller file to fix. But the format looks easy, I'll try to add it.

msfeldstein commented 8 years ago

Ah weird i could have sworn i had added it. Oh well, the steps are to add a file under controllers to map the buttons to css selectors, then add the domain-file mapping here: https://github.com/msfeldstein/chrome-media-keys/blob/master/src/background/mappings.coffee 22tracks shows a good example of a basic controller.

On Wed, Mar 9, 2016 at 4:06 PM Markus Birth notifications@github.com wrote:

I didn't find a Pocket Casts controller file to fix. But the format looks easy, I'll try to add it.

— Reply to this email directly or view it on GitHub https://github.com/msfeldstein/chrome-media-keys/issues/85#issuecomment-194579076 .

mbirth commented 8 years ago

Works fine now.