search

msgpack-rpc / msgpack-rpc-python

MessagePack RPC implementation for Python
205 stars 72 forks source link

Support for Unix Domain Socket #1

Open hvishwanath opened 11 years ago

hvishwanath commented 11 years ago

Hi

I have forked the base repo and added support for Unix domain sockets. My main objective was as less intrusion as possible in the base code, and come up with something which can be 'plug and played'.

I have created a new transport builder (transport->uds.py) and a new address object msgpackrps->udsaddress.py. I have some examples demonstrating how to use UDS instead of tcp/ip sockets for msgpack rpc. Please review my repository and let me know if you are okay with merging these changes.

hvishwanath commented 11 years ago

Please ignore multiple comments reading the same content. Its a goofup with eclipse and Egit.

repeatedly commented 11 years ago

In this weekend, I will check this pull request.

hvishwanath commented 11 years ago

Thanks. Let me know if you need any changes.

repeatedly commented 11 years ago

I have serveral comments:

Please remove these comments on top of each file. It is not msgpack-rpc-python style.

Please move USD usage to Example section, not top.

UDSADdress is not common name. LocalAddress is better and its class should be in msgpackrpc.address module.

Please fix these bugs.

See following example.

# OK
"""\
Foo
Bar
"""
# NG
"""Foo
Bar"""

Please apply above changes.

hvishwanath commented 11 years ago

Thanks for your review. Will update and get back. On Apr 21, 2013 2:06 PM, "Masahiro Nakagawa" notifications@github.com wrote:

I have serveral comments:

  • Author comment in each file.

Please remove these comments on top of each file. It is not msgpack-rpc-python style.

  • README

Please move USD usage to Example section, not top.

  • UDSAddress

UDSADdress is not common name. LocalAddress is better and its class should be in msgpackrpc.address module.

  • Test and sample code can't run on Python 3.

Please fix these bugs.

  • Document style

See following example.

OK"""\FooBar"""

NG"""HogeBar"""

Please apply above changes.

— Reply to this email directly or view it on GitHubhttps://github.com/msgpack-rpc/msgpack-rpc-python/pull/1#issuecomment-16717813 .

OrangeTux commented 9 years ago

Well, any chance that this will be merged?

hvishwanath commented 9 years ago

Been a long time! I didn't think people would like to use unix domain sockets with msgpackrpc, hence never got to updating the pull request. Will get to it shortly.

Regards, Harish

On Sat, Feb 14, 2015 at 6:31 PM, Auke Willem Oosterhoff < notifications@github.com> wrote:

Well, any chance that this will be merged?

— Reply to this email directly or view it on GitHub https://github.com/msgpack-rpc/msgpack-rpc-python/pull/1#issuecomment-74374159 .

mmontone commented 8 years ago

What happened with this merge? I would like to use it! :)

repeatedly commented 8 years ago

This patch doesn't apply my reviews so I can't merge. If you want to use this feature, apply the patch by your hand.