Use a more recent version of Tornado?

msgpack-rpc / msgpack-rpc-python

MessagePack RPC implementation for Python

205 stars 72 forks source link

Use a more recent version of Tornado? #24

Open tkazik opened 3 years ago

tkazik commented 3 years ago

Are there any plans to move towards a more recent version of Tornado? Airsim uses msgpack-rpc-python (related issue), which is not compatible with Tornado >= v5 (deliberate decision here). Unfortunately, the jupyter extension of VS Code needs Tornado >= v5. Are there any plans to update tornado to a more recent version? (Or are there not enough maintainers?) Thx!

csquires commented 3 years ago

Seconded!

xaedes commented 2 years ago

I forked the repo and included the tornado code of version 4.5.3 (highest version <5) directly into it. Changed all the imports so it uses its own copy of tornado 4.5.3.

This may not be the best solution, but for me it solves the issue. I can now use jupyterlab and notebook together with msgpack-rpc-python. The example works. It is hard to interrupt the server side tho...

https://github.com/xaedes/msgpack-rpc-python/tree/with_tornado_453

To use it, just clone it and checkout the branch with_tornado_453. Remove any existing installation of msgpack-rpc-python: pip uninstall msgpack-rpc-python

Install msgpack-rpc-python with integrated tornado from the local directory in which you cloned my fork, for example when you are currently in this directory: pip install .

tanyaspaul commented 1 year ago

same error did anyone find a solution? Currently having the issue below :

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
nbclassic 0.4.8 requires tornado>=6.1, but you have tornado 4.5.3 which is incompatible.
jupyter-server 1.21.0 requires tornado>=6.1.0, but you have tornado 4.5.3 which is incompatible.
jupyter-client 7.4.7 requires tornado>=6.2, but you have tornado 4.5.3 which is incompatible.
ipyparallel 8.4.1 requires tornado>=5.1, but you have tornado 4.5.3 which is incompatible.
ipykernel 6.15.2 requires tornado>=6.1, but you have tornado 4.5.3 which is incompatible.

But then when I upgrade tornado : ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. msgpack-rpc-python 0.4.1 requires tornado<5,>=3, but you have tornado 6.2 which is incompatible.