search

msgpack-rpc / msgpack-rpc-ruby

MessagePack-RPC Ruby Implementation
21 stars 14 forks source link

Upgrade cool.io to 1.2.x #3

Closed joker1007 closed 9 years ago

joker1007 commented 9 years ago

we cannot build cool.io-1.1.1 on ruby-2.2.0. I fixed cool.io version dependency, use cool.io ~> 1.2.4. And I fixes broken specs, old spec_helper, old Rakefile.

sonots commented 9 years ago

:+1:

repeatedly commented 9 years ago

:+1:

suma commented 9 years ago

:+1: Thank you for your PR. I got error like this when rake rspec executed with Ruby 2.2.0 and 2.1.5. Do you have any idea?

[note] Indentation is used spaces and tabs. Original code was written with tabs, so we(maintainer) should refine only newer specs.

joker1007 commented 9 years ago

@suma I think that this is because port choice is not safely. I fixed way of launching server, test is more stable.

suma commented 9 years ago

@joker1007 Thanks a lot! I released v0.5.3.