search

msgpack / msgpack-c

MessagePack implementation for C and C++ / msgpack.org[C/C++]
Other
3.03k stars 883 forks source link

make some headers self-contained #1011

Closed timblechmann closed 2 years ago

timblechmann commented 2 years ago

some headers are not self-contained, as they depend on symbols from headers which aren't included

codecov-commenter commented 2 years ago

Codecov Report

Merging #1011 (8b87e62) into cpp_master (63511f2) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##           cpp_master    #1011   +/-   ##
===========================================
  Coverage       85.56%   85.56%           
===========================================
  Files              79       79           
  Lines            5009     5009           
===========================================
  Hits             4286     4286           
  Misses            723      723
timblechmann commented 2 years ago

it's still not sufficient for all adaptor. e.g. for the ones depending on other adaptors. but it's a start ...

redboltz commented 2 years ago

I think that automatic self-contained cheking mechanism should be added. I did it on other project.

See: https://github.com/redboltz/mqtt_cpp/blob/master/include/CMakeLists.txt#L41-L60

Anyway, thank you for contributing. I merged the PR.

timblechmann commented 2 years ago

validating it automatically is definitely helpful. with recent cmake it can probably be done out of the box: https://cmake.org/cmake/help/latest/prop_tgt/VERIFY_INTERFACE_HEADER_SETS.html