search

msgpack / msgpack-c

MessagePack implementation for C and C++ / msgpack.org[C/C++]
Other
3.03k stars 883 forks source link

Unify all package related names to msgpack-c. #1053

Closed redboltz closed 1 year ago

redboltz commented 1 year ago

Update the version to 6.0.0.

carlocab commented 1 year ago

Renaming libmsgpackc to libmsgpack-c will break all software that links with libmsgpackc, because they don't know to look for libmsgpack-c instead.

Given that the SOVERSION has not changed, perhaps it would be good to provide symlinks from libmsgpack-c to libmsgpackc to avoid having to recompile dependent software (and patch their build systems in the meantime so they know they have to look for msgpack-c instead of just msgpack)?

redboltz commented 1 year ago

@carlocab

Thank you for the comment. The current SOVERSION is 2.0.0. I didn't update the SOVERSION because no function interface has been changed. But I noticed that library name is a part of public intercace. So SOVERSION should be updated to 3.0.0.

I will create the PR that updates SOVERSION from 2.0.0 to 3.0.0 and the msgpack-c version from 6.0.0 to 6.0.1. The reason updated to 6.0.1 is fixing the bug that is missing SOVERSION update.

What do you think?

carlocab commented 1 year ago

I think staying with the SOVERSION of 2.0.0 is fine. msgpack-c 6.0.0 is binary compatible with msgpack-c 5.0.0, so there is no need to force rebuilding of clients here.