search

msgpack / msgpack-c

MessagePack implementation for C and C++ / msgpack.org[C/C++]
Other
3.03k stars 883 forks source link

Fix to avoid common function name's (`has_as::check`) ambiguity/conflict with other libraries' macros #1085

Closed hiradyazdan closed 1 year ago

hiradyazdan commented 1 year ago

This is a minor change of a private function name, which can have a big impact for Unreal Engine's users to be able to use msgpack-cxx library as unfortunately some libraries, specially, Unreal Engine use badly named generic/common macro definitions (UE uses since v4.0) and no effort to modify their macro names to something more unique to their engine.

This issue fixes #1050 and was also raised and discussed in #626 in more depth.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1085 (e7f7b51) into cpp_master (8c602e8) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## cpp_master #1085 +/- ## =========================================== Coverage 85.75% 85.75% =========================================== Files 80 80 Lines 5091 5091 =========================================== Hits 4366 4366 Misses 725 725 ```