search

msgpack / msgpack-c

MessagePack implementation for C and C++ / msgpack.org[C/C++]
Other
3.01k stars 875 forks source link

Use GNUInstallDirs to set installation directories #1108

Closed Zopolis4 closed 6 months ago

Zopolis4 commented 6 months ago

Allow the user to override directories via typical options if necessary, otherwise use the GNU defaults.

Only change in behaviour is to install into ${prefix}/lib64 on systems where the following conditions are met.

  #  - we are on Linux system but NOT cross-compiling
  #  - we are NOT on debian
  #  - we are NOT building for conda
  #  - we are on a 64 bits system

Resolves #981

Zopolis4 commented 6 months ago

It seems like the AppVeyor CI fail is unrelated to my changes.

redboltz commented 6 months ago

It seems like the AppVeyor CI fail is unrelated to my changes.

Yes, I think so. But our human resource is very limited. In this case, I ask you to fix it even if it is not related to your fix. I've checked the appveyor error. The error is caused by non exisitng link http://zlib.net/zlib-1.3.tar.gz It should be http://zlib.net/zlib-1.3.1.tar.gz

Here is appveyor setup file: https://github.com/msgpack/msgpack-c/blob/2c0040cef6e0cd9f871979bb6e6b57fa74de0d46/appveyor.yml

Please try replacing all 1.3 to 1.3.1.

redboltz commented 6 months ago

I just merged your appveyor update pull requests. Could you rebase this PR from the merged cpp_master ?

codecov-commenter commented 6 months ago

Codecov Report

Merging #1108 (d1af4a3) into c_master (5f287d1) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## c_master #1108 +/- ## ========================================= Coverage 55.45% 55.45% ========================================= Files 8 8 Lines 1044 1044 ========================================= Hits 579 579 Misses 465 465 ```