search

msgpack / msgpack-cli

MessagePack implementation for Common Language Infrastructure / msgpack.org[C#]
http://msgpack.org
Apache License 2.0
835 stars 175 forks source link

Fix DictionarySerializationOptions typo #304

Closed shimat closed 6 years ago

shimat commented 6 years ago

🙏 I'm afraid of incompatibility with older versions. Should I use [Obsolete] ?

yfakariya commented 6 years ago

Yes, this is absolutely typo and they should be fixed, but this bug is not so critical to justify breaking API compatibility. So, it is better to remain old APIs with [Obsolete("Use DictionarySerializationOption instead.")] as you suggest, and put [EditorBrowsable(EditorBrowsable.Never)] to prevent new comers confusion.

Thank you for your contribution!

shimat commented 6 years ago

🙆‍♂️ I added the old named property.

yfakariya commented 6 years ago

Thank you, but there are some compilation errors because newly added files are not synchronized for some projects including Unity.

Would you run 

SyncProject.bat

and commit csproj change appropriately?

Thank you again for your contribution!