Fixed bugs in Derive.hs

msgpack / msgpack-haskell

Haskell implementation of MessagePack / msgpack.org[Haskell]

http://hackage.haskell.org/package/msgpack

138 stars 80 forks source link

Fixed bugs in Derive.hs #43

Closed sbeschke closed 5 years ago

sbeschke commented 10 years ago

This fixes two bugs in Derive.hs.

The first bug prevented compilation and was fixed by adding T.pack to convert String to Text.

The second bug relates to issue #38 and caused ADTs to be serialised improperly. Constructor alternatives were only distinguished by their field types, which led to problems if different constructors had the same field types. The fix is to include the constructor name in the serialised value.

iphydf commented 8 years ago

Derive.hs is commented out. This PR can no longer be merged as is.

hvr commented 5 years ago

Closing as TH-based derivation is currently no longer supported in current release