search

msgpack / msgpack-haskell

Haskell implementation of MessagePack / msgpack.org[Haskell]
http://hackage.haskell.org/package/msgpack
138 stars 80 forks source link

Fix MessagePack Maybe instance, add Maybe tests, fix msgpack-rpc tests, fix documentation #64

Closed akegalj closed 7 years ago

akegalj commented 8 years ago

Previous MessagePack Maybe instance was hanging. This patch should fix that. Tests for MessagePack were updated with Maybe tests.

Besides that, Maybe () was ambiguous with Maybe Nothing (Nothing was encoded as () was, with ObjectNil). To resolve it we have encoded () as empty vector. Using Maybe () doesn't make much sense, but here is the fix anyway.

On some machines, when using localhost as host for execClient, exception "Exception: connect: does not exist (Connection refused)" is thrown. I am not sure is this underlying OS problem, but as tests are run on the same machine it makes sense to change this to 127.0.0.1. This doesn't throw an exception.

Fix documentation runClient -> execClient.

volhovm commented 8 years ago

Any progress with merging?

iphydf commented 8 years ago

I independently fixed this issue a while ago in https://github.com/TokTok/hstox because I ran into it and was unaware of this PR. Recently, I split off that code into https://github.com/TokTok/hs-msgpack where the issue is also fixed. If you like, I can try to rebase my code on your branch.

iphydf commented 8 years ago

If you would like your changes to be part of a hackage package, consider contributing them to https://github.com/TokTok/hs-msgpack, which is released as https://hackage.haskell.org/package/data-msgpack.

iphydf commented 8 years ago

Congratulations, you have done the same work I did a few months ago: https://github.com/TokTok/hs-msgpack/blob/master/src/Data/MessagePack/Generic.hs

Why don't we work together?

akegalj commented 7 years ago

I will close it as it doesn't seem relevant any more. Reopen if needed