msgpack / msgpack-javascript

@msgpack/msgpack - MessagePack for JavaScript / msgpack.org[JavaScript/TypeScript/ECMA-262]
https://msgpack.org/
ISC License
1.28k stars 160 forks source link

let Encoder and Decoder accept named params as encode() and decode() do #224

Closed gfx closed 1 year ago

gfx commented 1 year ago

This is a major interface change even if the interfaces of Encoder and Decoder were not described in README.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 :tada:

Comparison is base (c4d65d6) 98.38% compared to head (a7efd6b) 98.58%.

:exclamation: Current head a7efd6b differs from pull request most recent head 842dc45. Consider uploading reports for the commit 842dc45 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #224 +/- ## ========================================== + Coverage 98.38% 98.58% +0.20% ========================================== Files 16 16 Lines 990 990 Branches 202 195 -7 ========================================== + Hits 974 976 +2 + Misses 16 14 -2 ``` | [Impacted Files](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack) | Coverage Δ | | |---|---|---| | [src/Decoder.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL0RlY29kZXIudHM=) | `99.19% <100.00%> (+<0.01%)` | :arrow_up: | | [src/Encoder.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL0VuY29kZXIudHM=) | `98.14% <100.00%> (+<0.01%)` | :arrow_up: | | [src/decode.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL2RlY29kZS50cw==) | `100.00% <100.00%> (ø)` | | | [src/decodeAsync.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL2RlY29kZUFzeW5jLnRz) | `100.00% <100.00%> (+9.52%)` | :arrow_up: | | [src/encode.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL2VuY29kZS50cw==) | `100.00% <100.00%> (ø)` | | | [src/index.ts](https://codecov.io/gh/msgpack/msgpack-javascript/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack#diff-c3JjL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.