msgpack / msgpack-javascript

@msgpack/msgpack - MessagePack for JavaScript / msgpack.org[JavaScript/TypeScript/ECMA-262]
https://msgpack.org/
ISC License
1.3k stars 162 forks source link

Fix ExtensionCodec example so it recurses. #225

Closed jcc10 closed 1 year ago

jcc10 commented 1 year ago

Fixes example so data doesn't get lost in recursion.

Creates valid workaround for #138

Spent about a hour before I realized the example was broken. 🤦‍♀️

gfx commented 1 year ago

Thank you! Yes, you are right, and I have also experienced the same issue before. It is a wrong design of the current interface, which I'd love to fix in the future.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (e615511) 98.58% compared to head (29a970f) 98.58%.

:exclamation: Current head 29a970f differs from pull request most recent head 07900e5. Consider uploading reports for the commit 07900e5 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #225 +/- ## ======================================= Coverage 98.58% 98.58% ======================================= Files 16 16 Lines 990 990 Branches 195 195 ======================================= Hits 976 976 Misses 14 14 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=msgpack)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.