search

msgpack / msgpack-ocaml

MessagePack implementation for OCaml / msgpack.org[OCaml]
45 stars 19 forks source link

drop camlp4 #12

Closed vbmithr closed 7 years ago

hcarty commented 8 years ago

This doesn't work for me when I build locally with --enable-all. It looks like _oasis hasn't been updated yet to build the ppx extension.

vbmithr commented 8 years ago

I'm unable to reproduce. Works like a charm for me.

hcarty commented 8 years ago

It was an opam switch mixup on my end - sorry for the noise! It works for me too.

ghost commented 8 years ago

So will it be accepted @hcarty @vbmithr ?

Leonidas-from-XIV commented 7 years ago

I have fixed the merge conflicts with current master in a branch, if you want you can just pull from there: https://github.com/Leonidas-from-XIV/msgpack-ocaml/tree/drop-camlp4

mzp commented 7 years ago

I merged from https://github.com/Leonidas-from-XIV/msgpack-ocaml/tree/drop-camlp4.

Thanks and sorry for delayed merge.