search

msgpack / msgpack-ocaml

MessagePack implementation for OCaml / msgpack.org[OCaml]
45 stars 19 forks source link

Rename base module #18

Closed Leonidas-from-XIV closed 7 years ago

Leonidas-from-XIV commented 7 years ago

Jane Street has a library called Base and this creates conflicts between the libraries. This PR is modelled after #6 which did a similar thing to the Config module, so feel free to just cherry-pick the interesting parts.

kit-ty-kate commented 7 years ago

It would be nice to have no more modules without the Msgpack prefix. For instance, Serialize could conflict for some programs or libraries.

Leonidas-from-XIV commented 7 years ago

I could look into migrating this library to jbuilder which defaults to creating "wrapped" libraries, which hides all modules behind one single, top-level module to not interfere with other modules in other libraries.

@mzp, would you be interested in such a change? I don't want to waste both our time if you have objections to this approach.

mzp commented 7 years ago

l have no objection for using jbuilder.

But I don't have experience in jbuilder, so it would be helpful if you join and maintenance around it.