search

msgpack / msgpack-ocaml

MessagePack implementation for OCaml / msgpack.org[OCaml]
45 stars 19 forks source link

Remove dependency to extlib #5

Closed andersfugmann closed 9 years ago

andersfugmann commented 10 years ago

This patch remove the dependency to extlib, as it makes possible to use msgpack in projects that also uses batteries.

Only two functions were used from extlib: String.implode and String.explode. These has been re-implemented manually and are tail recursive with a O(n) time complexity.

These have been placed close to where they are used in lib/core/serialize.ml. Also a change has been made to _oasis.

The rest of the changes are artifacts of the fact that the repository contains auto generated files, which are updated when the project is reconfigured.

rgrinberg commented 9 years ago

@andersfugmann Do you mind taking over this package and applying your 2 PR's in your fork? I'd really like to use this without extlib.

mzp commented 9 years ago

Oh sorry, I realize these pull requests today.. I'll review these pull requests, and release to opam in a few days.