remicollet commented 6 years ago

1st part is for 7.3 (fcc.initialized removed)

2nd is for 7.0+ (7.3 allow to raise to -Wformat warning and thus detect this issue)

remicollet commented 6 years ago

7.3 work is not done, still have to fix the recursion protection... (I don't have it for now...)

codecov-io commented 6 years ago

Codecov Report

Merging #125 into master will decrease coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   87.36%   87.29%   -0.07%     
==========================================
  Files           8        8              
  Lines        1250     1251       +1     
  Branches      222        0     -222     
==========================================
  Hits         1092     1092              
- Misses        158      159       +1

Impacted Files	Coverage Δ
msgpack_convert.c	`74.09% <ø> (ø)`	:arrow_up:
msgpack_unpack.c	`85.24% <ø> (ø)`	:arrow_up:
msgpack_class.c	`86.34% <0%> (-0.43%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 943d272...e8ddc2c. Read the comment docs.

Jan-E commented 6 years ago

7.3 work is not done, still have to fix the recursion protection... (I don't have it for now...)

Is not that in the other PR for 7.3: https://github.com/msgpack/msgpack-php/pull/124/commits/00f5383020e5c9be9e9503fc9f7f954dc73437e1

remicollet commented 6 years ago

@Jan-E indeed.

So I drop the part which is also in pr #124 and keep fix needed by 7.0+

remicollet commented 5 years ago

@laruence sadly this one was not merged in 2.0.3

Jan-E commented 5 years ago

Time for a 2.0.4

msgpack / msgpack-php

fix ce->name is a zend_string #125

Codecov Report