search

msgpack / msgpack-php

msgpack.org[PHP]
BSD 3-Clause "New" or "Revised" License
773 stars 119 forks source link

Add PHP 7.2 to the Travis CI matrix #129

Closed sodabrew closed 4 years ago

sodabrew commented 5 years ago

This PR will get PHP 7.1 and 7.2 fully tested. Then the PHP 7.3 PR #124 can be a bunch smaller and focus only on the recursion changes there.

sodabrew commented 5 years ago

@laruence @Sean-Der are you available begin a train to get to PHP 7.3? There will be a number of PRs on the way from myself and @remicollet

sodabrew commented 5 years ago

Hi! Is anybody available to support getting this module ready for the PHP 7.3 release?

Jan-E commented 5 years ago

Hi! Is anybody available to support getting this module ready for the PHP 7.3 release?

Try @remicollet See https://github.com/msgpack/msgpack-php/pull/124

andypost commented 5 years ago

FYI on aarch64 one test fails http://build.alpinelinux.org/buildlogs/build-edge-aarch64/community/php7-pecl-msgpack/php7-pecl-msgpack-2.0.3-r1.log

FAILED TEST SUMMARY
---------------------------------------------------------------------
Profiling perf test. [tests/035.phpt]
=====================================================================
sodabrew commented 4 years ago

Thank you @m6w6! You've been on a tear recently! Really appreciate your work sprucing up this module. I'll be sure to update my test suite in php-memcached to use the latest msgpack-php, I hope you'll tag all this great work into a formal release version soon.

m6w6 commented 4 years ago

Yes, I'm working on a new release.

And sorry, it looks like this PR could have been merged actually!