Use a runtime assert during init instead of _Static_assert

msgpack / msgpack-ruby

MessagePack implementation for Ruby / msgpack.org[Ruby]

http://msgpack.org/

Apache License 2.0

764 stars 117 forks source link

Use a runtime assert during init instead of _Static_assert #335

Closed byroot closed 1 year ago

byroot commented 1 year ago

Fix: https://github.com/msgpack/msgpack-ruby/issues/334

jmartin-tech commented 1 year ago

Have confirmed this works for the container referenced in #334, verified it builds successfully on Ruby 2.6.5 and Ruby 3.0.5.

byroot commented 1 year ago

Interesting, we got an assertion failure on Windows/3.2:

Assertion Failed: C:/hostedtoolcache/windows/Ruby/3.2.2/x64/include/ruby-3.2.0/ruby/internal/arithmetic/long.h:192:rbimpl_fix2long_by_shift:RB_FIXNUM_P(x)
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x64-mingw-ucrt]

No idea how to debug that though :/ So I'll merge this for now.