search

mshanemc / deploy-to-sfdx

the power behind hands-on workshops, demo booths, and platform trial
BSD 3-Clause "New" or "Revised" License
88 stars 43 forks source link

Too many console.log statements #63

Closed jrattanpal closed 4 years ago

jrattanpal commented 5 years ago

With the latest change, there is a console.log statement every 1-2 seconds. There are just too many logs in the end in browser console.

Can this be changed back to original where it only logged when status changed? sfdx_console_log_errors

mshanemc commented 5 years ago

Had to switch to polling because of browser support and firewall issues around web sockets.

What’s the issue caused by the logging?

On Sep 4, 2019, at 12:42 PM, jrattanpal notifications@github.com wrote:

With the latest change, there is a console.log statement every 1-2 seconds. There are just too many logs in the end in browser console.

Can this be changed back to original where it only logged when status changed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jrattanpal commented 5 years ago

It's not a blocker.

It just adds too many statements. My computer (macbook air) is slow and all these messages make it even slower.

in our case, it took about 15-20 minutes for app to install. And there were all these messages every 1-2 seconds during that and that was too many.

mshanemc commented 4 years ago

this is fixed...only logs when something about the CDS changes.