search

mshanemc / deploy-to-sfdx

the power behind hands-on workshops, demo booths, and platform trial
BSD 3-Clause "New" or "Revised" License
88 stars 43 forks source link

Browser messages late by 1 step #64

Closed jrattanpal closed 4 years ago

jrattanpal commented 5 years ago

In the browser, when any action happens, it shows the step after it happens.

For example, "1. creating an org" shows up after the org has been created rather than before.

mshanemc commented 5 years ago

true. have considered changing...would you rather know what it's doing right now (send before execution) or what just happened (change the label to past tense) or both

jrattanpal commented 5 years ago

Ideally both.

but if we only have 1 option then I'd like to know what it's doing right now. In our FSL (Field Service) package, it takes about 10-20 minutes to install that package.

But it's hard to know what is going on for users. So, if it can show that it's currently at package install then that'll be helpful.

As it is right now, it shows git init was done and nothing. Only the user who setup the repo knows that next step is install. But if we want to distribute it to non-technical users, they don't know what is going on. They have closed the window thinking it's stuck because it takes forever.

A side issue (which you are aware of) is sometimes the thread executing the process shuts down and it sits there forever. I remember you had mentioned that you plan to capture that KILL (or TERM?) message and show it to user that something happened and they should start again (or start automatically maybe)

mshanemc commented 5 years ago

the real question here is why you aren't using pools on something that takes 20 min?

yeah, I'll look at the messaging options.

jrattanpal commented 5 years ago

Mainly because I didn’t think about using pool for this use case. And this demo is not final and keeps changing so we can’t use it right now.

Also, requests for these orgs are not that common so we didn’t want to use pools for this. And this is also used for other demos and we didn’t want to open pools for anyone to use it

We also haven’t implemented that dynamic pool solution your team created using force.com site as we don’t have as high a usage as your team. But maybe it’s time to use that. I’ll work with the team

On Fri, Sep 20, 2019 at 4:33 PM Shane McLaughlin notifications@github.com wrote:

the real question here is why you aren't using pools on something that takes 20 min?

yeah, I'll look at the messaging options.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mshanemc/deploy-to-sfdx/issues/64?email_source=notifications&email_token=ABV6HLCPCLTMWFSSBULFRD3QKUXQXA5CNFSM4ITUV7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7HZXTA#issuecomment-533699532, or mute the thread https://github.com/notifications/unsubscribe-auth/ABV6HLEFPAEXU26QHMPYONTQKUXQXANCNFSM4ITUV7PQ .

--

Jaswinder Rattanpal www.rattanpal.com

mshanemc commented 4 years ago

fixed in current master (not in production yet, but is in test env)