Additional fix for custom setting name too long

bernadettebuck commented 4 years ago

Two changes in roundRobinAssigner:

Changed logic of nameshortener to put the reduction of the custom setting name length in a while loop until it's under 38 characters. This resolves an edge case where one of the three strings (Object Name, Field Name, Group Name) was a great deal longer than the others
Added an exception to be thrown when the public group being used for assignment has no members. This will also be thrown when the group does not exist.

Change to roundRobinTests to add a test for a particularly long object name.

bernadettebuck commented 4 years ago

Hi Shane -- finally got this done. We tested this code with one assignment group and it's working well. I haven't had time to test multiple groups yet.

This is primarily meant to help with issues #1 / #11 / #13. I put in the exception because we ran into it while testing, but it should also help with #21

I didn't try to install/run prettier but tried to keep things in your format.

mshanemc commented 4 years ago

I like the exceptions. It's always the crazy edge cases.

mshanemc / roundRobinProcessBuilder

Additional fix for custom setting name too long #23