msherry / flycheck-pycheckers

Multiple syntax checker for Python in Emacs, using Flycheck
GNU General Public License v3.0
63 stars 23 forks source link

Supporting additional checkers? #19

Closed ghost closed 6 years ago

ghost commented 6 years ago

I'm a big fan of flycheck-pycheckers. I ran across some additional checkers (most in prospector) that seem useful. I wonder how hard it'd be to include any of these in pycheckers?

msherry commented 6 years ago

We could definitely add support for more checkers! I don't use any of the checkers mentioned myself, and in fact have only heard of mccabe before (which I believe is included by default when running flake8, which is already supported by flycheck-pycheckers). I'd be willing to do some work to support more checkers if there's some demand/interest in them, but I don't want to add them just for the sake of having them, you know? Do you have a sense of which ones people would be most interested in seeing?

Alternatively, pull requests would help to get additional checkers merged in more quickly! :)

ghost commented 6 years ago

Cool. My best heuristic about demand would probably be the GitHub stars - I went ahead and added them to my post and sorted the list.

msherry commented 6 years ago

3629cfbacfefbe72bdc6a6a67c6859b558cdf003 adds support for Bandit, as by far the most-starred of the above list. I'm going to hold off on the others, as I'm so far unsure about how useful they may be. I'm still open to reviewing pull requests that add support for more checkers, if they solve a concrete use case for someone.

ghost commented 6 years ago

Sweet! I'm looking forward to using Bandit as soon as it shows up on MELPA. It's also cool that the clean commit history documents exactly what needs to be done for anybody interested in adding new checkers. :)

msherry commented 6 years ago

I'm going to close this issue out for now now that bandit is supported. If anyone is interested in adding new checkers, please submit a PR and I'll be happy to take a look! I'm also planning on reducing the boilerplate necessary to add a new checker, so hopefully this will become even easier in the future.