msherry / flycheck-pycheckers

Multiple syntax checker for Python in Emacs, using Flycheck
GNU General Public License v3.0
63 stars 23 forks source link

Try to locate the mypy.ini find in the project root. #20

Closed JulienPalard closed 5 years ago

JulienPalard commented 6 years ago

See https://github.com/msherry/flycheck-pycheckers/issues/3

I'm currently trying it, it can be improved as the search for the project root is done twice, it's currently "just a test".

msherry commented 6 years ago

This is a great start -- thanks for taking it on! I always provide the path to the mypy.ini file in the .pycheckers config file, so I haven't bothered to implement this yet, but this is definitely a great feature to add.

I think ideally we would look for this file by default, and allow any user-specified options to override it. What do you think?

JulienPalard commented 6 years ago

Why not, or searching for files mypy is typically using (mypy.ini with fallback to setup.cfg in the current directory, or .mypy.ini)? I think it could be added later as needed.

JulienPalard commented 5 years ago

@msherry is that better?

msherry commented 5 years ago

Oops, this fell off my radar -- I apologize for that. Yes, this looks good now! Thanks for making the requested fixes.