search

msherry / flycheck-pycheckers

Multiple syntax checker for Python in Emacs, using Flycheck
GNU General Public License v3.0
63 stars 23 forks source link

Only pass max_line_length when a value is specified #31

Closed thieman closed 3 years ago

thieman commented 5 years ago

The current behavior has the effect of always passing a value for --max-line-length to the checkers. At least in Flake8 (admittedly, the only checker I'm using currently), this takes precedence over the max line length value I've specified in my config file which is not the desired behavior.

thieman commented 5 years ago

I've realized I think I also need to change the .el for this to really work, will need to look into the best way to do that

msherry commented 5 years ago

Thanks for looking into this! I agree, now that flycheck-pycheckers handles config files a bit better than it used to, the command-line arguments are less correct (but also less necessary, at least).

Take a look at #13, which made some similar changes to the --ignore-codes option to handle a non-supplied argument differently. It may give some ideas on how to handle this.