search

msherry / flycheck-pycheckers

Multiple syntax checker for Python in Emacs, using Flycheck
GNU General Public License v3.0
63 stars 23 forks source link

Do not require inferred executable names to be on PATH if overriding #55

Closed posita closed 4 years ago

posita commented 4 years ago

No longer fail when self.command cannot be found if it won't actually be used.

This assumes that if {}_command is provided, it points to something executable. One oddity here is that if it does not, there isn't a useful error message printed anywhere that I can find. That may be okay.

Fixes #53. Obsoletes #54.

posita commented 4 years ago

One tangential observation: It's confusing (from both a user and developer standpoint) that there's a distinction between self.name and self.command. The contexts in which each applies isn't intuitive. I'm wondering if both are needed?

msherry commented 4 years ago

One tangential observation: It's confusing (from both a user and developer standpoint) that there's a distinction between self.name and self.command. The contexts in which each applies isn't intuitive. I'm wondering if both are needed?

So this is mostly for mypy -- the executable for both python2 and py3 is mypy, so I wanted a way to distinguish which version was failing, while still running the same underlying command. I agree that this is confusing and I'm not thrilled with it, but I like the functionality it provides, so... Definitely willing to listen to suggestions for improvements, though!