search

msherry / flycheck-pycheckers

Multiple syntax checker for Python in Emacs, using Flycheck
GNU General Public License v3.0
63 stars 23 forks source link

.pycheckers ignore_codes has no effect #8

Closed DanSchoppe closed 6 years ago

DanSchoppe commented 6 years ago

I couldn't seem to get the ignore_codes setting from my .pycheckers file to take effect. Example contents:

[DEFAULT]
checkers=pylint
ignore_codes=C0410,C0111

After troubleshooting pycheckers.py, it looks like the issue is caused by inconsistent use of "ignore_codes" vs "ignored_codes". For example, the relevant CLI arg to pycheckers.py is --ignore-codes. This gets parsed into options.ignored_codes. But that means that update_options_locally() would parse the ignore_codes setting from my .pycheckers file into a new options.ignore_codes key. Similar story for the .pycheckers extra_ignore_codes option.

Although I'm not aware of any bugs related to "enable" vs "enabled", it might be a good time to examine that usage as well.

I propose the present tense "ignore" and "enable" be consistently used and all instances of "ignored" and "enabled" be changed. I don't see any issues that would arise due to "ignore". Regarding "enable", the emacs variable flycheck-pycheckers-enabled-codes would be affected.