search

msiebuhr / charcod.es

Small webpage for finding the odd unicode char code.
https://charcodes.netlify.app/
ISC License
18 stars 3 forks source link

defer() doesn't insert Google Analytics code. #24

Closed msiebuhr closed 12 years ago

msiebuhr commented 12 years ago

The defer(url, callback) doesn't insert the DOM-element for fetching the script in the DOM. Specifically, the following line seem to be broken:

firstScript.parentNode.insertBefore(inc, firstScript);

Can you look into it, @munter?

Munter commented 12 years ago

I can't recreate this.

msiebuhr commented 12 years ago

Weird. I was pretty sure I had it nailed to the defer(...)-function (and now it actually seem to work in both Chrome and FF).

But fact remains that no data has shown up in Analytics since July 14th, which seem to correlate with commit 60980b850665caa3a594202e988f5f10175fbeb1 on July 15th (the only commit around that day that touches the GA code).

Any other guesses as to why it doesn't work?

Munter commented 12 years ago

Mistake on my part. Declared _gaq as a local variable. Fix coming up