Unnoticed LGPE => SWSH Sprite Changes

sora10pls commented 3 years ago

Related: #103

Turns out, after looking at the above issue, there are a handful of large sprites from LGPE that got very minor adjustments in SWSH that went unnoticed for a long time. The affected species are (from that I've noticed):

Charizard
Clefable
Vileplume
Machamp
Rapidash
Cloyster
Gengar
Onix
Kingler
Hitmonchan
Seaking
Mr. Mime (included because your prior commit uses a sprite that's slightly misaligned with the sprite from my ROM dump)
Gyarados
Lapras
Snorlax
Mewtwo
Melmetal

Attached here are all of the Kanto Pokémon sprites (+ Meltan/Melmetal) dumped from the SWSH ROM. The above list is just the ones I noticed, but maybe you'll find other, smaller oddities.

Some were simply shifted a few pixels over (Charizard, Lapras) while some others received some minor updates (Rapidash's flames are now outlined black, Kingler is a brighter orange, among other changes).

Rapidash from this repository: Rapidash from SWSH ROM: poke_icon_0078_00s_n

msikma commented 3 years ago

Thank you for reporting these, and sorry for being late. I'm going to get started on them when I've got some time soon.

msikma commented 2 years ago

Well, "when I've got some time soon" ended up being never. I'll make sure to have this done this week though, I've been ignoring this repo for far too long!

msikma commented 2 years ago

I think they're all correct now. If I didn't miss anything I'll push the update. charizard clefable cloyster gengar gyarados hitmonchan kingler lapras machamp melmetal mewtwo mr-mime onix rapidash seaking snorlax vileplume

charizard_shiny clefable_shiny cloyster_shiny gengar_shiny gyarados_shiny hitmonchan_shiny kingler_shiny lapras_shiny machamp_shiny melmetal_shiny mewtwo_shiny mr-mime_shiny onix_shiny rapidash_shiny seaking_shiny snorlax_shiny vileplume_shiny