search

msikma / pokesprite

Database project of box and inventory sprites from the Pokémon core series games
https://msikma.github.io/pokesprite/
MIT License
972 stars 167 forks source link

Gourgeist #15

Closed Droidem closed 7 years ago

Droidem commented 7 years ago

Hey there!

Thanks for everything you have done for this. This is an amazing project.

I noticed you finished your update but I can't find the shiny Gourgeist Alternate Forms. Would it be possible for them to be added when you get a chance?

5310 commented 7 years ago

I've redrawn alternate sized sprites for the Gourgeist family and can make a PR if they're acceptable:

Droidem commented 7 years ago

I seriously wasn't expecting a response so quickly! They look awesome btw. Thank you for this.

5310 commented 7 years ago

I read earlier that @msikma wants to avoid sprites for regular species that aren't in the game as well, so I'll wait until he replies to this issue before making the PR, if at all 😸

msikma commented 7 years ago

Well, I recently also added icons for female Hippopotas and Hippowdon, so I guess there's no reason not to add these. The other two were simple recolors and these are actually new sprites, so it might be good to add them as alternate icons, e.g. under gourgeist-super-alt instead of gourgeist-super. I'm not sure. It's hard to be consistent, because it also sounds good to be clear about what is and isn't official.

5310 commented 7 years ago

Great! So currently I have the sprites as just gourgeist-super, and I've also edited the data/pkmn.json and removed the duplicate flag from all six of these new sprites, as well as removed the duplicate files from the icon/pokemon/regular/duplicates folder because it looked like that was the intent behind that folder. How should I go about renaming them to gourgeist-super-alt, etc?

My current changes are in this branch: 5310/pokesprite[gourgeist]

Alternatively, how about having a sprite-sheet template that only has strictly official sprites, and another that has the unofficial extensions, shinies, rights, alternates et al?

5310 commented 7 years ago

Any thoughts on this @msikma? About what I should edit or the non-canonical template?

5310 commented 7 years ago

I would still like to help get this issue resolved. If @msikma would reply with what's holding it up or what I should do in terms of structuring my PR.

msikma commented 7 years ago

Sorry for being absent. I'll look at this again this weekend.

msikma commented 7 years ago

So although I really like your changes, I kind of wanted to make some very small amendments to the icons. I don't have write access to your Gourgeist branch, but I think if you make a PR I should get access (or if not you can grant me access). Also the icons should be PNG32 files, rather than PNG8.

I've made some very small edits to the icons, if you can give me access I'll commit them. Then I'll do some testing to ensure the JSON etc is correct and merge the PR.

5310 commented 7 years ago

Oops, I hadn't realized the bit-depth was different. And sorry for the delay.

I've given you collaborator access to the repository. Please let me know if there's any changes I can help with for the PR.

msikma commented 7 years ago

I pushed those changes, let me know what you think. Also, feel free to make a PR. I'll do my final checks then.

5310 commented 7 years ago

Will do!

On Mon, Apr 24, 2017 at 3:38 PM Michiel Sikma notifications@github.com wrote:

I pushed those changes, let me know what you think. Also, feel free to make a PR. I'll do my final checks then.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/msikma/pokesprite/issues/15#issuecomment-296604479, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG5El65NpAToN7GB4MAkF7dBuxVlNvBks5rzHSygaJpZM4LJ1z9 .

msikma commented 7 years ago

Again sorry for absence—going to look at this tomorrow and merge.

msikma commented 7 years ago

Finally merged. I noticed some icons weren't updated for shiny yet...then it turns out I just hadn't pulled yet. However, I think Pumpkaboo-Super wasn't updated, so I added that. I'll make a new build now.

5310 commented 7 years ago

Oops! I forgot to even add super to the branch! Sorry about that. Also, hurray!

On Sun, May 7, 2017, 14:10 Michiel Sikma notifications@github.com wrote:

Finally merged. I noticed some icons weren't updated for shiny yet...then it turns out I just hadn't pulled yet. However, I think Pumpkaboo-Super wasn't updated, so I added that. I'll make a new build now.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/msikma/pokesprite/issues/15#issuecomment-299690781, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG5Eg7RUlkShSoRzPfBK5zTSQyoY9xTks5r3YNggaJpZM4LJ1z9 .

msikma commented 7 years ago

Updated the build.