Closed GiacomoLaw closed 7 years ago
Bit unexpected but this is cool π
There's one major issue that prevents me from merging this: the button CSS was added to pokesprite.min.css - this file gets automatically generated (along with every other file inside build/
), so if I ever made an update it would delete your button CSS. Since it's just a few lines of code, you can just include it as an inline CSS block in the header.
That's easily fixed, other than that I have the following suggestions:
overview.min.css
file so that it's loaded before the <script>
tag. This is my mistake, all CSS should be above the Javascript.I'll merge this if you are interested in changing these things.
Okay, no problem. Will do soon!
@msikma Done! π
Updated. Is that fine :D
There's a few more changes I would like. But I'll just merge this later and then show you what I meant...
Hope you didn't mind all my comments too much. π
No, it's fine! Sorry about that.
Merged it. Thanks. Made a few more minor changes: https://github.com/msikma/pokesprite/commit/7c3bd55d3a2fbbe6007334842021ffba233964c0
No problem π
I wasn't sure about the button color, so I made it black. Please ask if you want me to change something else.
You can view a demo of it here π