msikma / pokesprite

Database project of box and inventory sprites from the PokΓ©mon core series games
https://msikma.github.io/pokesprite/
MIT License
972 stars 167 forks source link

Made view on Github into button #22

Closed GiacomoLaw closed 7 years ago

GiacomoLaw commented 7 years ago

I wasn't sure about the button color, so I made it black. Please ask if you want me to change something else.

You can view a demo of it here πŸ˜„

msikma commented 7 years ago

Bit unexpected but this is cool πŸ˜„

There's one major issue that prevents me from merging this: the button CSS was added to pokesprite.min.css - this file gets automatically generated (along with every other file inside build/), so if I ever made an update it would delete your button CSS. Since it's just a few lines of code, you can just include it as an inline CSS block in the header.

That's easily fixed, other than that I have the following suggestions:

I'll merge this if you are interested in changing these things.

GiacomoLaw commented 7 years ago

Okay, no problem. Will do soon!

GiacomoLaw commented 7 years ago
GiacomoLaw commented 7 years ago

@msikma Done! πŸ˜ƒ

GiacomoLaw commented 7 years ago

Updated. Is that fine :D

msikma commented 7 years ago

There's a few more changes I would like. But I'll just merge this later and then show you what I meant...

Hope you didn't mind all my comments too much. πŸ˜„

GiacomoLaw commented 7 years ago

No, it's fine! Sorry about that.

msikma commented 7 years ago

Merged it. Thanks. Made a few more minor changes: https://github.com/msikma/pokesprite/commit/7c3bd55d3a2fbbe6007334842021ffba233964c0

GiacomoLaw commented 7 years ago

No problem πŸ˜„