msikma / pokesprite

Database project of box and inventory sprites from the Pokémon core series games
https://msikma.github.io/pokesprite/
MIT License
958 stars 164 forks source link

Gen8 icons aren't aligned the same #62

Closed Kanimi closed 4 years ago

Kanimi commented 4 years ago

Please see the following two examples: https://raw.githubusercontent.com/msikma/pokesprite/master/pokemon-gen8/regular/grookey.png https://raw.githubusercontent.com/msikma/pokesprite/master/icons/pokemon/regular/pikachu.png

As you can see the grookey sprite seems to have extra space which can be seen easily if you copy image and paste it next to gen 1-7 ones in paint - https://prnt.sc/rfqcsf

This causes Pokemon to not be aligned and not displaying properly in tabs as seen here: https://tinyurl.com/Kanimi-Pokemon

Any reason for the extra space on the new sprites?

Also unless I am blind there's no koffing-galar or weezing-galar.

msikma commented 4 years ago

There are actually three different sets:

When developing applications using these icons, you should preferably use /pokemon-gen8 only. You can simply use: https://raw.githubusercontent.com/msikma/pokesprite/master/pokemon-gen8/regular/pikachu.png which is the correct size.

The old /icons directory is only for legacy support. These icons are 40x30, while in Gen 8 the icons have been updated to 68x56.

Koffing-galar does not exist, but weezing-galar is here: https://github.com/msikma/pokesprite/blob/master/pokemon-gen8/shiny/weezing-galar.png - it's only available in the new Gen 8 set.

Let me know if this helps.

Kanimi commented 4 years ago

Would you know then why some of the Pokemon sprites are not showing up at all? Especially having replaced the legacy icons with the new ones. pokemon

msikma commented 4 years ago

I'm not sure. However, the legacy /icons directory contains both inventory items and Pokémon, and the new /pokemon-gen7x and /pokemon-gen8 directories only contain Pokémon, so you need to make sure to remove the extra /pokemon/ section from the URL if you're replacing it. E.g. /icons/pokemon/regular/hitmonchan.png needs to become /pokemon-gen8/regular/hitmonchan.png. I suggest you double check the URLs in your app/sheet.

For example, Seel and Hitmonchan and others are missing from your image, but they're there:

rawr51919 commented 4 years ago

Agreed. This isn't actually an issue with pokesprite, but with your particular deployment of it. This can therefore be closed

msikma commented 4 years ago

Just had another look at the spreadsheet, looks like it's working now? Let me know if anything else comes up, I don't mind having a look.