msikma / pokesprite

Database project of box and inventory sprites from the Pokémon core series games
https://msikma.github.io/pokesprite/
MIT License
958 stars 164 forks source link

Sprites with transparent pixels trimmed? #75

Closed martimlobao closed 1 year ago

martimlobao commented 4 years ago

Wondering if it's possible to have the new sprites with the transparent pixels cropped out. I understand that having them all conform to a standard of 68 by 56 pixels makes sense for a lot of use cases, but trying to use them in Google Sheets makes a lot of sprites tiny and hard to see.

For example, Grookey's actual height is about 25 pixels, but since the image height is 56, it shrinks down to half the size of the row. On the other hand, Eternatus's Eternamax form takes up the entire 56 pixels, so it's also not possible to simply crop all sprites to half the height in Google Sheets.

Image cropped to actual sprite height (taken from serebii.net):

Screen Shot 2020-06-15 at 18 45 00

Sprites in 68x56 box:

Screen Shot 2020-06-15 at 18 45 20
msikma commented 4 years ago

This is a good point and it would also help people trying to center the sprites vertically, rather than having them appear "on the ground".

I'm open to the idea, and it wouldn't be too hard to do since I can just run the trim filter on every file. I'll look into it.

Lekiyoshi commented 4 years ago

Just a note, when using Google Sheets in a PC in edit mode or view mode, but not published, sprites become blurred if they are centered vertically or horizontally and have "mismatched" size with the cell width or height. So, if the point of cropping the sprites would be for Sheets usage only, it would be better if all the new sprites have all even or all odd number of pixels for width and height.

msikma commented 4 years ago

Now that the DLC update is done, it's time to look into this again. I'm thinking it might be a good idea to make a special fork of this project with trimmed sprites, that way this repo can remain simple.

atmize1027 commented 3 years ago

Please unsubscribe me from this thread's notifications. Thank you.

On Mon, Jun 15, 2020, 1:59 PM Martim Lobao notifications@github.com wrote:

Wondering if it's possible to have the new sprites with the transparent pixels cropped out. I understand that having them all conform to a standard of 68 by 56 pixels makes sense for a lot of use cases, but trying to use them in Google Sheets makes a lot of sprites tiny and hard to see.

For example, Grookey's actual height is about 25 pixels, but since the image height is 56, it shrinks down to half the size of the row. On the other hand, Eternatus's Eternamax form takes up the entire 56 pixels, so it's also not possible to simply crop all sprites to half the height in Google Sheets.

Image cropped to actual sprite height (taken from serebii.net https://www.serebii.net/pokedex-swsh/icon/810.png): [image: Screen Shot 2020-06-15 at 18 45 00] https://user-images.githubusercontent.com/6430786/84689132-6d007f80-af38-11ea-83f3-882fc250c13e.png Sprites in 68x56 box: [image: Screen Shot 2020-06-15 at 18 45 20] https://user-images.githubusercontent.com/6430786/84689151-72f66080-af38-11ea-89ba-7ce27767042e.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/msikma/pokesprite/issues/75, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWZ3MRLHGJ2HHJ4SUZE6ZTRWZOO3ANCNFSM4N6M4MJQ .

msikma commented 3 years ago

@atmize1027, unfortunately I can't unsubscribe you, the only way for that to happen is for you to unsubscribe yourself.

martimlobao commented 1 year ago

Implemented in separate fork here: https://github.com/martimlobao/pokesprite