search

msikma / pokesprite

Database project of box and inventory sprites from the Pokémon core series games
https://msikma.github.io/pokesprite/
MIT License
958 stars 164 forks source link

Sword and Shield Mark "ribbons"? #78

Closed ThomasHineXYZ closed 4 years ago

ThomasHineXYZ commented 4 years ago

Adding in marks would be handy, but personally I believe that they should go in to their own folder in the misc section, not lumped in with ribbons like Serebii does it...

https://www.serebii.net/swordshield/marks.shtml https://www.serebii.net/games/ribbons.shtml

msikma commented 4 years ago

Thanks for letting me know about this. And I agree, they should be in their own section.

msikma commented 4 years ago

@guitaristtom would you happen to know if there are any new ribbons as of the DLC?

I've just taken all marks + their data from this page and I'll be adding them separately from the ribbons, in the misc section, but I'm just wondering now if there are new ribbons to add too while I'm at it.

koenigderluegner commented 4 years ago

@msikma i checked the ribbons list, i was looking for galar champion ribbon and didnt see it (at least not under galar-XXX) when was the last time you added ribbons? are sword/shield ribbons there using different names?

msikma commented 4 years ago

The Galar champion ribbon is under misc/ribbon/gen8/galar-champion-ribbon.png. I put those in a separate directory because they're 128x128 while the others are 40x40.

msikma commented 4 years ago

The marks have been added to #80.

ThomasHineXYZ commented 4 years ago

@guitaristtom would you happen to know if there are any new ribbons as of the DLC?

I've just taken all marks + their data from this page and I'll be adding them separately from the ribbons, in the misc section, but I'm just wondering now if there are new ribbons to add too while I'm at it.

Sorry, I have been AFK for a few days.

From my knowledge no new ribbons or marks were added to the DLC (at least with IoA).