search

msikma / pokesprite

Database project of box and inventory sprites from the Pokémon core series games
https://msikma.github.io/pokesprite/
MIT License
958 stars 164 forks source link

add trimmed versions of pokemon-gen8 with transparent pixels removed #90

Closed martimlobao closed 1 year ago

martimlobao commented 3 years ago

Images were trimmed using ImageMagick, then framed with a 3px transparent border. Contains all images currently in pokemon-gen8/. Images came out slightly larger (by an average of 20%) than the originals, despite being trimmed versions. I'm not sure how to fix that, but they're all still extremely small (less than 1.9MB for all 2.6k images) so this isn't a huge deal imo.

Closes #75.

msikma commented 3 years ago

Hi there, thanks for your contribution and sorry for not being able to respond for so long.

The images are probably a little bigger because they haven't gone through pngcrush. There's a script for this in the repo.

One thing is that I'm not 100% sure it's best to keep trimmed versions in this repo—it might be better off in a fork. What are your thoughts about this? The main reason is I'd prefer to keep this repo simple, and adding trimmed versions of only the Gen 8 sprites (and not the older sprites, the items, etc.) seems a bit specific as use case. That way the docs can be made specific to the trimmed images as well, since everything written about e.g. image size no longer applies. Would it be an idea to have a fork that contains only these trimmed sprites, and the data files, and nothing else?

Also, a question, I see you made a commit adding a 3px transparent border, can you explain why it should specifically be 3px?

martimlobao commented 3 years ago

No problem, and I completely agree with your point that this might be an overly specific use case. That's also essentially the reason I added the 3px border on the images: when viewing them in Google Sheets, the lack of a transparent border made the images too close together.

With border:

Screen Shot 2020-10-22 at 11 40 09

Without border:

Screen Shot 2020-10-22 at 11 42 29

If you think there's any added value in keeping these images in this repo (I'm probably not the only person using them for Google Sheets), I'd be happy to reorganize them a little (perhaps renaming the folder from trim to sheets to indicate they work better for that use case), as well as add trimmed versions of every other image in the repo for consistency. Otherwise, I'm perfectly fine with keeping these in a separate fork as well.

Either way, I'll take a look at the png crush script to reduce the image sizes :)

JohnEstropia commented 3 years ago

@martimlobao Might be unrelated to this PR, but I see that you have the new Crown Tundra Pokemon in your fork. Do you have a source for the new icons? I've been looking for updated sprites for the pre-CT Pokemon (not just the new ones) as some of them have changed (as reported in https://github.com/msikma/pokesprite/issues/92)

martimlobao commented 3 years ago

@JohnEstropia I added them from serebii.net. I think the new versions mentioned in #92 are also there, but since I don't have the shiny versions, I don't want to update them until I have both.

JohnEstropia commented 3 years ago

@martimlobao Thanks for your response. It looks like Serebii uses tiny icons for every pokemon except for the updated icons in #92, which are all in the standard sizes we use here in Pokesprite. I guess that works for us for now

martimlobao commented 1 year ago

Closing this PR since https://github.com/martimlobao/pokesprite contains trimmed versions under pokemon-gen8/