search

msimerson / mail-dmarc

Mail::DMARC, a complete DMARC implementation in Perl
Other
33 stars 23 forks source link

Undeclared dependency Net::SMTPS #167

Closed eserte closed 4 years ago

eserte commented 4 years ago

The test suite fails if Net::SMTPS is not installed:

Output from './Build test':

Can't locate Net/SMTPS.pm in @INC (you may need to install the Net::SMTPS module) (@INC contains: lib /var/tmp/cpansmoker-1023/2020010900/9BE3UDk5Kn /home/cpansand/.cpan/build/2020010901/Mail-DMARC-1.20200108-ciOrYs/blib/lib /home/cpansand/.cpan/build/2020010901/Mail-DMARC-1.20200108-ciOrYs/blib/arch /home/cpansand/.cpan/build/2020010901/Net-IP-1.26-Ne63Fj/blib/arch /home/cpansand/.cpan/build/2020010901/Net-IP-1.26-Ne63Fj/blib/lib /home/cpansand/.cpan/build/2020010901/DBIx-Simple-1.37-x5dwa_/blib/arch /home/cpansand/.cpan/build/2020010901/DBIx-Simple-1.37-x5dwa_/blib/lib /usr/perl5.20.1Dp/lib/site_perl/5.20.1/amd64-freebsd-ld /usr/perl5.20.1Dp/lib/site_perl/5.20.1 /usr/perl5.20.1Dp/lib/5.20.1/amd64-freebsd-ld /usr/perl5.20.1Dp/lib/5.20.1 .) at lib/Mail/DMARC/Report/Send/SMTP.pm line 10.
BEGIN failed--compilation aborted at lib/Mail/DMARC/Report/Send/SMTP.pm line 10.
Compilation failed in require at lib/Mail/DMARC/Report/Send.pm line 8.
BEGIN failed--compilation aborted at lib/Mail/DMARC/Report/Send.pm line 8.
Compilation failed in require at lib/Mail/DMARC/Report.pm line 14.
Compilation failed in require at lib/Mail/DMARC.pm line 12.
Compilation failed in require at /usr/perl5.20.1Dp/lib/5.20.1/parent.pm line 20.
BEGIN failed--compilation aborted at t/00.Dmarc.t line 343.
t/00.Dmarc.t ................................. 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
... (etc) ...
msimerson commented 4 years ago

Hmmm, I do declare Net::SMTPS, but it is declared as a recommends and part of an optional feature. I'll just lazy load it in ::SMTP, so the test file can load ::SMTP when Net::SMTPS is not installed.