Closed rjbs closed 9 years ago
Please test that 8b58411 solves #1 for you.
I updated the docs to reflect that new(spf=>this) takes an arrayref of hashrefs (generally a scope=mfrom and scope=helo). It's a lot more punctuation than $dmarc=>spf( %hash ) but works equally for both invocation methods.
I've also stubbed in some tests that do everything but supply a Mail::DKIM::Verifier object. I couldn't quickly figure out how to mock up a perl coderef that works for $dkim->signatures or I'd have done so myself.
I tried to get a Mail::DMARC::PurePerl via
new
, but hit a couple snags.dkim
argument in new, only via thedkim
setter. If you do, you get "dkim needs to be an array reference!"spf
argument in new, because it wants an arrayref. If you pass the documented pairs as an arrayref, you get "Can't use string ("domain") as a HASH ref while "strict refs"". Maybe it wants an arrayref of hashrefs, but I gave up at that point.The
new
method and the individual setters, for these two at least, have very different behaviors. Please either make them the same, or document each.Thanks!