search

msimerson / maxmind-geolite-mirror

Mirror MaxMind GeoIP dbs from geolite.maxmind.com
https://www.npmjs.com/package/maxmind-geolite-mirror
MIT License
10 stars 5 forks source link

publish new version? #19

Closed sbma44 closed 6 years ago

sbma44 commented 6 years ago

@msimerson 1.0.9 includes changes to the config file to include the ASN tarball, but not the code that handles it properly -- the published version suffers from the "tar file as mmdb" issue. Could you publish a new version containing the code presently in master?

msimerson commented 6 years ago

I should have asked you to update CHANGES and bump the version number in your PR. I expect a test file PR soon (either from you, or perhaps me next week when I have a little extra time) and we can do a version bump and release there.

sbma44 commented 6 years ago

Sounds good. While I have you: any objection to me adding “use strict” for node 4 compatibility? I’m working to get some internal projects updated given the node 4 EOL but this might smooth the way for my own internal PR.

msimerson commented 6 years ago

Hah, my last PR just removed use strict because node 4 is EOL. It doesn't hurt anything so I don't mind. Shucks, it it comes with tests I'd find it nearly impossible to say no. ;) Also, include an update to Changes and a version bump and I'll kick out a new release.

msimerson commented 6 years ago

fixed by #20