search

msimerson / maxmind-geolite-mirror

Mirror MaxMind GeoIP dbs from geolite.maxmind.com
https://www.npmjs.com/package/maxmind-geolite-mirror
MIT License
10 stars 5 forks source link

pass errors up to caller via cb (vs ignore or throw) #24

Closed msimerson closed 5 years ago

msimerson commented 5 years ago

fixes #23

codecov[bot] commented 5 years ago

Codecov Report

Merging #24 into master will increase coverage by 0.57%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   76.59%   77.17%   +0.57%     
==========================================
  Files           3        3              
  Lines          94       92       -2     
  Branches       15       14       -1     
==========================================
- Hits           72       71       -1     
+ Misses         22       21       -1
Impacted Files Coverage Δ
lib/mm-geolite-mirror.js 74.68% <83.33%> (+0.6%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3072a0...4a4fd95. Read the comment docs.